Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant clone (to_string()) #217

Merged
merged 1 commit into from
Jun 3, 2023
Merged

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Jun 3, 2023

It was implemented to make a copy by to_string(), but it is actually unnecessary, so it will be removed.
It was warned by clippy.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
It was implemented to make a copy by to_string(), but it is actually unnecessary, so it will be removed.
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8a22596) 79.67% compared to head (2e7781d) 79.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #217   +/-   ##
=======================================
  Coverage   79.67%   79.67%           
=======================================
  Files          17       17           
  Lines        1766     1766           
=======================================
  Hits         1407     1407           
  Misses        359      359           
Flag Coverage Δ
unittests 79.67% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/git.rs 92.49% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kitsuyui kitsuyui merged commit 717fb15 into main Jun 3, 2023
@kitsuyui kitsuyui deleted the remove-redundant-clone branch June 3, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants