Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Add test for command line #128

Merged
merged 4 commits into from
Feb 18, 2023
Merged

Refactoring: Add test for command line #128

merged 4 commits into from
Feb 18, 2023

Conversation

kitsuyui
Copy link
Owner

@kitsuyui kitsuyui commented Feb 18, 2023

main in main.rs is for parsing command line arguments.
It's better to add test for this part.

assert_cmd makes it easy to write test.

@codecov-commenter
Copy link

codecov-commenter commented Feb 18, 2023

Codecov Report

Base: 75.82% // Head: 76.58% // Increases project coverage by +0.75% 🎉

Coverage data is based on head (66d044c) compared to base (9261440).
Patch coverage: 84.52% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   75.82%   76.58%   +0.75%     
==========================================
  Files          15       15              
  Lines        1299     1341      +42     
==========================================
+ Hits          985     1027      +42     
  Misses        314      314              
Flag Coverage Δ
unittests 76.58% <84.52%> (+0.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main.rs 50.00% <84.52%> (+17.79%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kitsuyui kitsuyui changed the title WIP: Refactoring Refactoring: Add test for command line Feb 18, 2023
@kitsuyui kitsuyui merged commit dbc70dc into main Feb 18, 2023
@kitsuyui kitsuyui deleted the refactor branch February 18, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants