Calculate the default timeout correctly #6287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to a unit mix-up, the default timeout was only set to 1/60 of the intended time period, which occasionally causes errors in large images that you have to find first.
stweil
approved these changes
Nov 8, 2024
| @@ -51,7 +51,7 @@ class ConvertRunner { | |||
| /** | |||
| * Default timeout. | |||
| */ | |||
| private static final int DEFAULT_TIMEOUT_MINS = (int) TimeUnit.MINUTES.convert(2, TimeUnit.HOURS); | |||
| private static final int DEFAULT_TIMEOUT_SECS = (int) TimeUnit.SECONDS.convert(2, TimeUnit.HOURS); | |||
There was a problem hiding this comment.
I wonder whether 7200, 2 * 3600 or 2 * 60 * 60 would not be easier to read. At least it would avoid the type cast.
There was a problem hiding this comment.
The type cast could also be avoided by using a long DEFAULT_TIMEOUT_SECS and KitodoConfig.getLongParameter below.
| @@ -51,7 +51,7 @@ class ConvertRunner { | |||
| /** | |||
| * Default timeout. | |||
There was a problem hiding this comment.
Even if we have a speaking variable name, "Default timeout (seconds)" or a similar description might help additionally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a unit mix-up, the default timeout was only set to 1/60 of the intended time period, which occasionally causes errors in large images that you have to find first.