Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require global role editing permission to see global authorities #6286

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

solth
Copy link
Member

@solth solth commented Oct 31, 2024

This pull request adds the check suggested in #5837 and hides the "Global authorities" on the "Role edit" page when the user does not have the permission to globally edit a role:

Bildschirmfoto 2024-10-31 um 08 38 25

@pontus-osterdahl does this work for you?

Fixes #5837

Copy link
Collaborator

@henning-gerhardt henning-gerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes looks good and a simple functional test was positive. If possible the original author of the issue should look into this too.

@pontus-osterdahl
Copy link
Contributor

Looks good!

@solth solth merged commit 8faef1c into kitodo:master Nov 17, 2024
5 checks passed
@solth solth deleted the edit-role-globally branch November 17, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User with only client authority to edit roles can still add global authorities to role
3 participants