Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problem that SqlGrammarException is not catched with MySQL 5.7 #5562

Conversation

thomaslow
Copy link
Collaborator

@thomaslow thomaslow commented Feb 23, 2023

See issue #5563

@solth
Copy link
Member

solth commented Mar 7, 2023

@m-kotzyba can you confirm that the change in this pull request resolves the issue for you with a MySQL 5.7 database, too?

@m-kotzyba
Copy link
Collaborator

@solth Unfortunately, I can't make any statement on this, i.e., neither confirm nor deny. The update of our Kitodo and system in general (including MySQL) was the first choice for various reasons.

@solth
Copy link
Member

solth commented Mar 8, 2023

@thomaslow please rebase against the current master as your PR is the next merge candidate

@thomaslow
Copy link
Collaborator Author

@solth Github doesn't report any merge conflicts to me. Not sure what I am supposed to do.

@solth
Copy link
Member

solth commented Mar 8, 2023

@thomaslow Github only reports syntactic conflicts, but not semantic problems. We had multiple occassions where no merge conflicts would be reported between an - outdated - branch and the master branch and the corresponding pull request passed all automatic checks (Codacy, automatic tests etc.). After merging the pull request, though, the resulting code would fail at some new test in the master branch because the tested functionality was changed by the pull request.

So basically just rebase your branch against the current master or merge the current master into you branch to update it and verify that all automatic checks pass.

@thomaslow
Copy link
Collaborator Author

@solth FYI, there is a new beta feature in GitHub that should help you with merging by automatically re-running actions before merging: merge queues.

@solth
Copy link
Member

solth commented Mar 9, 2023

FYI, there is a new beta feature in GitHub that should help you with merging by automatically re-running actions before merging: merge queues.

@thomaslow thanks alot for the hint. @henning-gerhardt already suggested this new Github feature to me, I just haven't gotten around to activate and configure it, yet!

@subhhwendt & @joerg-liebenow could you approve this PR once you successfully tested the branch with your test system with MySQL 5.7 database?

@solth solth self-requested a review March 31, 2023 07:24
Copy link
Member

@solth solth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and can confirm that the change fixes the linked issue.

@solth solth merged commit e092770 into kitodo:master Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indexing of processes fails in kitodo-production 3.5.0 with mysql 5.7 due to recursive query
3 participants