Add functional metadata for 'docType' metadata #4906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthias-ronge
suggested changes
Jan 13, 2022
| @@ -111,17 +113,23 @@ public NodeList getMetadataNodes() { | |||
| * of type "docType" and if its value equals the type of the logical root element. If not, the | |||
| * logical root is set to the value of the "docType" metadata. | |||
| * | |||
| * This function is currently only used for the import of prestructured processes. | |||
| * <p>This function is currently only used for the import of prestructured processes.</p> | |||
There was a problem hiding this comment.
Please put the <p> on a single line (or Eclipse will reformat it sooner or later).
AFAIK, </p> should not be used in Javadoc.
Kitodo/src/main/java/org/kitodo/production/services/data/ImportService.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/helper/TempProcess.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/data/ImportService.java
Outdated
Show resolved
Hide resolved
Kitodo/src/main/java/org/kitodo/production/services/data/ImportService.java
Outdated
Show resolved
Hide resolved
|
@matthias-ronge thank you for the review. I implemented most of your requested changes, apart from the |
matthias-ronge
approved these changes
Jan 14, 2022
solth
force-pushed
the
doc-type-metadata
branch
from
ac2db20 to
124b009
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4863
Note: if this pull request is merged, mapping files and rulesets must be updated to include a metadata with
use="docType"in order for import to continue to work!Edit: also fixes #3389, I think