Make the contextMenu in StructurePanel und in GalleryPanel identical #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solth
reviewed
Mar 31, 2021
There was a problem hiding this comment.
This is a rather small technical change, but I believe it will help working with the metadata editor considerably! 👍
Just one small nitpick: the context menu in the gallery does not disappear when clicking somewhere else, for example when selecting a different stripe:
Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/AddDocStrucTypeDialog.java
Show resolved
Hide resolved
Kitodo/src/main/webapp/WEB-INF/templates/includes/metadataEditor/gallery.xhtml
Outdated
Show resolved
Hide resolved
Kitodo/src/main/webapp/WEB-INF/templates/includes/metadataEditor/logicalStructure.xhtml
Outdated
Show resolved
Hide resolved
IkramMaalej
force-pushed
the
gallery-context-menu
branch
from
8fe372e to
0be4898
Compare
|
please resolve conflicts |
IkramMaalej
force-pushed
the
gallery-context-menu
branch
from
0be4898 to
da737cb
Compare
IkramMaalej
force-pushed
the
gallery-context-menu
branch
from
da737cb to
50f499d
Compare
solth
requested changes
Apr 14, 2021
Kitodo/src/main/webapp/WEB-INF/templates/includes/metadataEditor/gallery.xhtml
Outdated
Show resolved
Hide resolved
…or/gallery.xhtml Co-authored-by: Arved Solth <solth@effective-webwork.de>
solth
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3646