Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ocr-highlighting plugin with MiniOCR #673

Merged
merged 99 commits into from
Oct 5, 2021
Merged

Conversation

albig
Copy link
Collaborator

@albig albig commented Sep 21, 2021

Just a PR to discuss the current state.

kselmi and others added 30 commits July 12, 2021 10:09
added: information on communication and support structure; demo server
Actually isIndexRemapped is not needed as fields are using config variables which have defined default values equal to fields names in default SOLR schema of Kitodo Presentation.
It is needed for cases when document id is passed by url instead by simple id used in index or database.
…URL schema, implement correctly

displaying of the links
Plugin has return only one snippet per page as default. Restore getHighlighting without assigning it to the variable.
After this adjustments displaying and highlighting of the results in image works.
Previous check was converting numeric string to int if it was starting with number
Source pointer can't be on any other server han SOLR, so it is not usable here.
+ add working logging for document and indexing
Either because of incorrect solr core or because some errors while indexing
beatrycze-volk
beatrycze-volk previously approved these changes Sep 22, 2021
Copy link
Collaborator

@beatrycze-volk beatrycze-volk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have looked over the code and tested changes. It seems to be cleaned out and working properly (indexing of the documents and searching in the document).

@beatrycze-volk beatrycze-volk self-requested a review September 27, 2021 09:27
beatrycze-volk
beatrycze-volk previously approved these changes Sep 27, 2021
@albig albig requested a review from beatrycze-volk October 5, 2021 13:31
@albig albig merged commit 85f5d2e into master Oct 5, 2021
@albig albig deleted the ocr-highlighting-plugin branch October 5, 2021 17:02
@albig albig added this to the Kitodo.Presentation 3.3.0 milestone Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants