-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ocr-highlighting plugin with MiniOCR #673
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added: information on communication and support structure; demo server
Actually isIndexRemapped is not needed as fields are using config variables which have defined default values equal to fields names in default SOLR schema of Kitodo Presentation.
It is needed for cases when document id is passed by url instead by simple id used in index or database.
…URL schema, implement correctly displaying of the links
Plugin has return only one snippet per page as default. Restore getHighlighting without assigning it to the variable.
After this adjustments displaying and highlighting of the results in image works.
Previous check was converting numeric string to int if it was starting with number
Source pointer can't be on any other server han SOLR, so it is not usable here.
+ add working logging for document and indexing
Either because of incorrect solr core or because some errors while indexing
beatrycze-volk
force-pushed
the
ocr-highlighting-plugin
branch
from
September 22, 2021 17:52
606bccb
to
63e4021
Compare
beatrycze-volk
previously approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have looked over the code and tested changes. It seems to be cleaned out and working properly (indexing of the documents and searching in the document).
beatrycze-volk
previously approved these changes
Sep 27, 2021
Fix HTML generation for full text
Update README.md
…esentation into ocr-highlighting-plugin
Ignore width and height as it can differ with results returned from OCR plugin
Create id only from begin position of the text
beatrycze-volk
approved these changes
Oct 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a PR to discuss the current state.