Footer styling #17
Merged
Footer styling #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sneridagh
reviewed
Dec 20, 2022
Closed
steffenri
reviewed
Dec 22, 2022
src/theme/_header.scss
Outdated
| padding-bottom: 0.5rem; | ||
| padding-top: 0; | ||
|
|
||
| @media only screen and (max-width: $tablet-breakpoint) { |
There was a problem hiding this comment.
@sneridagh @danalvrz So we have container queries now. Doesn't that make media queries obsolete? I wonder if it complicates things if we use both.
There was a problem hiding this comment.
Great questions, I am not sure, but would be happy to find a different implementation if it does complicate things
There was a problem hiding this comment.
I think we will probably want to look at using container queries, but I would leave it until Victor is back and in a new PR.
davisagli
reviewed
Dec 27, 2022
davisagli
reviewed
Dec 27, 2022
davisagli
reviewed
Dec 27, 2022
davisagli
approved these changes
Dec 27, 2022
iRohitSingh
added a commit
that referenced
this pull request
Jul 11, 2023
steffenri
pushed a commit
that referenced
this pull request
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding: https://github.com/kitconcept/bfs-intranet/issues/26
Screenshot:
