fix: handle falsy properties

kitajs · Jul 30, 2023 · 706d692 · 706d692
1 parent 158ff5b
commit 706d692
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/index.js b/index.js
@@ -180,7 +180,7 @@ function attributesToString (attributes) {
   const keys = Object.keys(attributes)
   const length = keys.length
 
-  let key, value, formattedName, escaped
+  let key, value, formattedName
   let result = ''
   let index = 0
 
@@ -211,12 +211,15 @@ function attributesToString (attributes) {
 
       continue
     }
-
+
+    if (value === null || value === undefined) {
+      continue
+    }
+
     result += ' ' + formattedName
-    escaped = escapeHtml(value)
 
-    if (escaped !== '') {
-      result += '="' + escaped + '"'
+    if (value !== '') {
+      result += '="' +  escapeHtml(value) + '"'
     }
   }
 

diff --git a/test/falsy.test.tsx b/test/falsy.test.tsx
@@ -11,4 +11,9 @@ test('falsy values', () => {
     </>,
     'false'
   )
+
+  assert.equal(
+    <div id="truthy" hidden={false} spellcheck={true} translate={undefined}></div>,
+    '<div id="truthy" spellcheck></div>'
+  )
 })