Lazy completion loading for Zsh #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add some comments next to the conditional describing what zsh_eval_context is expected to be when evaluating a shell completion autoload script vs. a script sourced directly by an rc file or shell command. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #475 +/- ##
========================================
Coverage 81.17% 81.17%
========================================
Files 10 10
Lines 786 786
========================================
Hits 638 638
Misses 148 148 ☔ View full report in Codecov by Sentry. |
|
@kislyuk Added a comment |
|
Hmm, that is not a comment and it is not what I was looking for. |
segevfiner
force-pushed
the
lazy-zsh-completion
branch
from
9c561e2 to
faf8ee0
Compare
segevfiner
commented
Mar 3, 2024
|
LGTM, thanks. |
|
Released in v3.2.3, please test |
segevfiner
added a commit
to segevfiner/yargs
that referenced
this pull request
Jul 7, 2024
Currently when you use the generated completion script in Zsh via autoloading, it doesn't provide completions on the first tab press. This is because when Zsh autoloads a completion script, it expects it to directly generate completions, this little trick allows it to be directly evaluated and used as an autoloaded script. P.S. I think if the shell function is named the same as the autoloaded script, Zsh will call it directly on subsequent calls, bypassing the rest of the script, e.g. the `if` code below. See https://zsh.sourceforge.io/Doc/Release/Functions.html#Autoloading-Functions See kislyuk/argcomplete#475
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can simply save the completion script into a directory in the
$fpathand it will work, the Homebrew formula for pipx already does that, but it doesn't work without this changeFixes #473