test and fix check blanks in var declarations #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gburt
commented
Jan 11, 2023
gburt
commented
Jan 11, 2023
|
btw thanks for this work, we're very glad to have it helping make our code better! |
|
Thanks very much for the thorough PR. Looks good to me but it seems there are some failing tests. Could you please take a look? |
|
doh I'd just been running |
|
now we just need to make a "you visited AssignStmt but not GenDecl" linter :) |
|
Waiting for #221 to merge before merging this. |
kisielk
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
var foo, _ = bar()blanks weren't getting checked becauseast.GenDeclstatements (a subset of which arevardeclarations) weren't being handled/visited. Fix that, and add back the analyzer tests for blank (and assert) flags.To handle them, I refactored the existing assignment check. It's completely unchanged except it now takes LHS and RHS args that we feed it from both the GenDecl and AssignStmt nodes' values.