Skip to content

Commit

Permalink
Make //executorch/backends/apple/mps:mps build internally (pytorch#3641)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: pytorch#3641

Was getting linker errors due to missing foundation framework, and need to deploy to recent macOS SDK.

Reviewed By: cccclai

Differential Revision: D57456696

fbshipit-source-id: a8b35d4c09d357bb6d68259a46e2dbcf5bbd98eb
  • Loading branch information
swolchok authored and facebook-github-bot committed May 16, 2024
1 parent 524703f commit 36f83eb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions backends/apple/mps/targets.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,13 @@ def define_common_targets(is_xplat = False, platforms = []):

if is_xplat:
kwargs["fbobjc_frameworks"] = [
"Foundation",
"Metal",
"MetalPerformanceShaders",
"MetalPerformanceShadersGraph",
]
kwargs["fbobjc_ios_target_sdk_version"] = "17.0"
kwargs["fbobjc_macosx_target_sdk_version"] = "14.0"
kwargs["platforms"] = platforms

if runtime.is_oss or is_xplat:
Expand Down

0 comments on commit 36f83eb

Please sign in to comment.