Simplify Install Task & Precompile Initializer #18
Conversation
Ancez
commented
Apr 9, 2022
•
Ancez
commented
- moved the if to be done inline so now instead of adding 3 lines, it adds 1 line to the layout
Ancez
changed the title
|
@kirillplatonov let me know what you think of these changes 🙂 I hope you are well I also wonder whether we could somehow get the js include tag to not be required in the app layout as realistically we want it in all the layouts (my example being the devise layout) so we either should be looping over all the layouts and inserting it to all of these or somehow get this outside of the app layouts 🤔🤷♂️ |
lib/hotwire/livereload/engine.rb
Outdated
| Rails.application.config.assets.precompile += %w( hotwire-livereload.js ) | ||
| end | ||
| initializer 'hotwire_livereload.assets.precompile' do |app| | ||
| app.config.assets.precompile += %w( hotwire-livereload.js ) |
There was a problem hiding this comment.
I think we still need to check if config responds to assets as the app might not use sprockets and use https://github.com/rails/propshaft instead.
There was a problem hiding this comment.
yep! Great call, I've updated the PR 🙌
this is something I've got to add to my gem too 😆 noticed it on one of the projects
|
@Ancez one-line installer looks good to me 🙂 As for alternatives for including a livereload tag in the layout - I'm not sure about that. We could probably add rack middleware or |
| @@ -15,7 +15,7 @@ class Engine < ::Rails::Engine | |||
| #{root}/app/helpers | |||
| ) | |||
|
|
|||
| initializer "hotwire_livereload.assets" do | |||
| initializer 'hotwire_livereload.assets' do | |||
There was a problem hiding this comment.
what're your thoughts on the usage of single quotes instead? I tend to stick to single quotes unless I need variables in the string
