-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: Fix for Query with Special Characters Failing Against Overseer #134
Bug: Fix for Query with Special Characters Failing Against Overseer #134
Conversation
The-Running-Dev
commented
Feb 6, 2024
- Modified Overseerr call to encode the query parameter
- Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.
- Modified Overseerr call to encode the query parameter - Added new util function, url-encode-illegal-characters (sources from hato.middleware) but with URL encoding all non alpha-numeric characters.
- Re-ordered string replacement to fix double encoding
This is a good solution for now - but I think I need to figure out why hato wasn't URL-encoding everything. |
You know this issue...you commented on the Overseer repo...sct/overseerr#2010 Look at my last comment here. https://www.reddit.com/r/Clojure/comments/1akfy0a/comment/kp9v1eo/?context=3 |
And I had promptly forgotten about it. |
…6.3@426517f by renovate (#18133) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [ghcr.io/kiranshila/doplarr](https://togithub.com/kiranshila/Doplarr) | patch | `v3.6.2` -> `v3.6.3` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kiranshila/Doplarr (ghcr.io/kiranshila/doplarr)</summary> ### [`v3.6.3`](https://togithub.com/kiranshila/Doplarr/releases/tag/v3.6.3) [Compare Source](https://togithub.com/kiranshila/Doplarr/compare/v3.6.2...v3.6.3) #### What's Changed - Add extra detail to Discord configuration instructions by [@​jconnop](https://togithub.com/jconnop) in [https://github.com/kiranshila/Doplarr/pull/109](https://togithub.com/kiranshila/Doplarr/pull/109) - Bug: Fix for Query with Special Characters Failing Against Overseer by [@​The-Running-Dev](https://togithub.com/The-Running-Dev) in [https://github.com/kiranshila/Doplarr/pull/134](https://togithub.com/kiranshila/Doplarr/pull/134) #### New Contributors - [@​jconnop](https://togithub.com/jconnop) made their first contribution in [https://github.com/kiranshila/Doplarr/pull/109](https://togithub.com/kiranshila/Doplarr/pull/109) - [@​The-Running-Dev](https://togithub.com/The-Running-Dev) made their first contribution in [https://github.com/kiranshila/Doplarr/pull/134](https://togithub.com/kiranshila/Doplarr/pull/134) **Full Changelog**: kiranshila/Doplarr@v3.6.2...v3.6.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone Europe/Amsterdam, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xODMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE4My4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->