This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
docs/metallb: Clarify address_pools knob #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current sample config is confusing. The address_pools knob is a map with string keys and lists of strings as values. There are no knobs named "default" or "special_addresses". These were intended as sample names for pools. Fixes #632.
johananl
changed the title
invidian
reviewed
Sep 22, 2020
johananl
force-pushed
the
johananl/metallb-pool-docs
branch
from
c6018fa to
e255f77
Compare
ipochi
reviewed
Sep 23, 2020
johananl
force-pushed
the
johananl/metallb-pool-docs
branch
from
e255f77 to
f91295b
Compare
|
I've addressed the feedback. |
invidian
previously approved these changes
Sep 25, 2020
iaguis
reviewed
Sep 28, 2020
johananl
force-pushed
the
johananl/metallb-pool-docs
branch
from
f91295b to
2631fda
Compare
invidian
approved these changes
Oct 8, 2020
iaguis
approved these changes
Oct 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR clarifies the proper usage of the
address_poolsknob of themetallbcomponent.