This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pkg/assets: cleanup exported API #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
invidian/simplify-assets-handling
branch
3 times, most recently
from
79dc14e to
61e80dd
Compare
invidian
force-pushed
the
invidian/simplify-assets-handling
branch
from
61e80dd to
2db4d4d
Compare
surajssd
previously approved these changes
Sep 23, 2020
So API of pkg/assets can be simplified. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
To ensure, that all files are only readable by the active user, as they may contain secrets. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This function is an internal detail of assets package and should not be part of the API for other packages. As it is not used externally anymore, we can unexport this function. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
As Extract() function is the only one which accesses Assets variable, we can convert it to unexported function. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
FLUO component was the last user of it and it is not used anymore, so it can be removed. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This commit revamps pkg/assets to use unexported types where possible, so now exported API of assets package is just Extract() function. Closes #796 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/simplify-assets-handling
branch
from
2db4d4d to
78a0d6b
Compare
|
Ping @johananl |
knrt10
reviewed
Oct 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes commits from #935This PR finishes cleaning up API of
pkg/assetspackage, so end result is, that only exported function we have isExtract().See commit messages for more details.
Closes #796