This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
rook ceph: Add CSI plugin affinity & toleration attribute #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
reviewed
Sep 2, 2020
| DiscoverTolerationEffect string `hcl:"discover_toleration_effect,optional"` | ||
| EnableMonitoring bool `hcl:"enable_monitoring,optional"` | ||
| CSIPluginNodeSelector util.NodeSelector `hcl:"csi_plugin_node_selector,optional"` | ||
| CSIPluginNodeAffinity string |
There was a problem hiding this comment.
Why not CSIPluginNodeSelectorRaw?
There was a problem hiding this comment.
By tacit convention *Raw has been for those that can simply be converted from it's hcl (json) form to the yaml and provided as it is. But *NodeAffinity is a rook's format of specifying the selector like this: key1=value1; key2=value2;.
There was a problem hiding this comment.
I think it would still be fine as Raw is sort of template-ready format, but I'm fine with it as it is 👍
This commit adds two new attributes: `csi_plugin_node_selector` and `csi_plugin_toleration` which will enable the plugin pods to install the necessary plugins on non-ceph nodes. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-rook-csi-toleration
branch
from
092e6e9 to
f3560d4
Compare
invidian
approved these changes
Sep 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two new attributes:
csi_plugin_node_selectorandcsi_plugin_tolerationwhich will enable the plugin pods to install thenecessary plugins on non-ceph nodes.