This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Update cert-manager to v0.16.1 #847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
reviewed
Aug 25, 2020
assets/charts/components/cert-manager/templates/letsencrypt-clusterissuer-prod.yaml
Outdated
Show resolved
Hide resolved
assets/charts/components/cert-manager/templates/letsencrypt-clusterissuer-staging.yaml
Outdated
Show resolved
Hide resolved
knrt10
force-pushed
the
knrt10/update-cert-manager
branch
from
598b02d to
4f1df9b
Compare
knrt10
force-pushed
the
knrt10/update-cert-manager
branch
from
4f1df9b to
3f7dc13
Compare
|
@knrt10 did you encounter any issues during upgrade from the last version? |
surajssd
reviewed
Aug 25, 2020
Release: https://github.com/jetstack/cert-manager/releases/tag/v0.16.1 Fixes #843 Signed-off-by: knrt10 <kautilya@kinvolk.io>
Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/update-cert-manager
branch
from
3f7dc13 to
c38ab1e
Compare
|
I only tried applying new one it worked fine, let me try upgrading from previous version |
|
@surajssd upgrade worked fine
|
|
@knrt10 the right way to test is if the cert-manager generates certificate after the upgrade. |
|
Yes tested that too |
|
@surajssd . Before applying cert-manager again, I build lokoctl with new updates in new terminal window. It does not show that
|
invidian
approved these changes
Aug 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #843
Signed-off-by: knrt10 kautilya@kinvolk.io