This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Use fmt.Errorf instead of errors.Wrap where error handling make sense #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
requested review from
ipochi,
johananl,
mauriciovasquezbernal and
surajssd
as code owners
invidian
force-pushed
the
invidian/errors-wrap
branch
from
aff3a40 to
210270f
Compare
|
Isn't @johananl changing those in the files related to platform package as part of his refactoring PR ? |
I'm not sure how is this related. The platform package refactoring PR is not even opened yet, but still it's focus would be different. |
|
@invidian should we add //TODOs in the same commit? |
I can't come up with any pro or con for committing it separately vs committing it together, maybe except that doing it together is a bit less work. So I'm not sure 😄 |
invidian
force-pushed
the
invidian/errors-wrap
branch
from
210270f to
f3b9137
Compare
johananl
reviewed
Aug 24, 2020
invidian
force-pushed
the
invidian/errors-wrap
branch
from
f3b9137 to
65b6db1
Compare
|
Thanks for reviewing @johananl, I addressed all your comments, please have a look again. |
johananl
reviewed
Aug 24, 2020
johananl
reviewed
Aug 24, 2020
johananl
previously approved these changes
Aug 24, 2020
This commit partially addresses issue #59, which encourages to use new error wrapping semantics available since Go 1.13, using %w formatting verb instead of 3rd party 'pkg/errors' package. This commit changes errors handling code from using errors.Wrap with fmt.Errorf where error handling should remain as is. For other uses of errors.Wrap, it adds a comment with TODO how code should be changed to either avoid or delegate error handling to someone else. This commit also changes error phrasing to the format we agreed in #59. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Our codebase and vendor/ directory prefers 'marshaling' over 'marshalling', so this commit changes last remaining occurence of unmarshalling to be consistent with rest of the error messages. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/errors-wrap
branch
from
65b6db1 to
8cfd6fe
Compare
johananl
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit partially addresses issue #59, which encourages to use new
error wrapping semantics available since Go 1.13, using %w formating
verb instead of 3rd party 'pkg/errors' package.
This commit changes errors handling code from using errors.Wrap with
fmt.Errorf where error handling should remain as is. For other uses of
errors.Wrap, it adds a comment with TODO how code should be changed to
either avoid or delegate error handling to someone else.
Signed-off-by: Mateusz Gozdek mateusz@kinvolk.io