This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pkg/terraform: remove OutputBytes #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, terraform package will do the unmarshalling for us. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This function is not used anywhere anymore and we have Output() as an alternative, which will be more convinient to use in most of the cases, as it automatically unmarshalls the output into given struct. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
requested review from
ipochi and
mauriciovasquezbernal
as code owners
johananl
approved these changes
Aug 21, 2020
I didn't test that, will do. |
|
It's probably enough to verify you can see the prompt with the DNS records to be configured. |
|
I verified, that I can see a DNS entries prompt properly, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for reasoning.