Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

docs: Add "How to upgrade etcd" #802

Merged
merged 1 commit into from
Aug 19, 2020
Merged

docs: Add "How to upgrade etcd" #802

merged 1 commit into from
Aug 19, 2020

Conversation

surajssd
Copy link
Member

No description provided.

@surajssd surajssd mentioned this pull request Aug 14, 2020
Merged
invidian
invidian suggested changes Aug 14, 2020
View reviewed changes
docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from 18f16d9 to f5d24e0 Compare August 14, 2020 11:01
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch 2 times, most recently from 48b034e to 7b2f3be Compare August 14, 2020 11:32
@surajssd surajssd requested review from rata and invidian August 14, 2020 11:32
rata
rata reviewed Aug 14, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajssd cool, thanks for writing this. Is super helpful!

I didn't verified the steps myself, though.

Added some questions, but this mostly LGTM :)

docs/how-to-guides/upgrade-etcd.md Show resolved Hide resolved
docs/how-to-guides/upgrade-etcd.md Show resolved Hide resolved
docs/how-to-guides/upgrade-etcd.md Show resolved Hide resolved
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from 7b2f3be to fbb60db Compare August 14, 2020 13:13
@surajssd
Copy link
Member Author

@rata done :-) Added the note on step 2 that it is needed only for deployments done using 0.4.0.

@surajssd surajssd requested a review from iaguis August 18, 2020 15:02
invidian
invidian previously approved these changes Aug 18, 2020
View reviewed changes
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from fbb60db to 7c0e233 Compare August 19, 2020 06:54
invidian
invidian previously approved these changes Aug 19, 2020
View reviewed changes
rata
rata previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment about when it is safe or not to continue (maybe being extra paranoid or cases that can't really happen :)).

Marking as approve as it might be a no-op and just answer my question without changes :)

docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
@surajssd surajssd dismissed stale reviews from rata and invidian via fd056ae August 19, 2020 09:28
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from 7c0e233 to fd056ae Compare August 19, 2020 09:28
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from fd056ae to 2cae55e Compare August 19, 2020 10:46
invidian
invidian previously approved these changes Aug 19, 2020
View reviewed changes
ipochi
ipochi reviewed Aug 19, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @surajssd.

Small nits.

docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
docs/how-to-guides/upgrade-etcd.md Outdated Show resolved Hide resolved
rata
rata previously approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I only have this concern, but I understand it might not need changes or can be done in a following PR :)

@surajssd surajssd dismissed stale reviews from rata and invidian via f16946a August 19, 2020 11:10
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from 2cae55e to f16946a Compare August 19, 2020 11:10
@surajssd
docs: Add "How to upgrade etcd"
2b12057 
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/add-etcd-upgrade-doc branch from f16946a to 2b12057 Compare August 19, 2020 11:11
@surajssd surajssd requested a review from ipochi August 19, 2020 11:12
ipochi
ipochi approved these changes Aug 19, 2020
View reviewed changes
Copy link
Member

@ipochi ipochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@surajssd surajssd merged commit a3f4a4e into master Aug 19, 2020
@surajssd surajssd deleted the surajssd/add-etcd-upgrade-doc branch August 19, 2020 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rata rata rata left review comments

@ipochi ipochi ipochi approved these changes

@invidian invidian invidian left review comments

@johananl johananl Awaiting requested review from johananl

@knrt10 knrt10 Awaiting requested review from knrt10

@iaguis iaguis Awaiting requested review from iaguis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@surajssd @rata @ipochi @invidian