Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Release v0.3.0 #740

Merged
merged 4 commits into from
Jul 31, 2020
Merged

Release v0.3.0 #740

merged 4 commits into from
Jul 31, 2020

Conversation

ipochi
Copy link
Member

@ipochi ipochi commented Jul 29, 2020 •
edited
Loading

Signed-off-by: Imran Pochi imran@kinvolk.io

@ipochi ipochi requested review from johananl and surajssd as code owners July 29, 2020 14:53
@ipochi ipochi changed the title CHANGELOG.md: add changelog for v0.3.0 release Release : v0.3.0 Jul 29, 2020
@ipochi ipochi requested review from iaguis and invidian July 29, 2020 14:54
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch 2 times, most recently from 0d3cce2 to 6a08c46 Compare July 29, 2020 15:36
rata
rata reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipochi awesome, thanks a lot!

Added some comments, my biggest concern is if the default change can't cause to loose all the cluster data (etcd)

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
invidian
invidian suggested changes Jul 29, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Largely LGTM. I added some comments about some bits, which I think should be corrected/clarified.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated

>It is highly recommended to schedule a downtime for the application using the
>OpenEBS PV while performing this upgrade. Also, make sure you have taken a
>backup of the data before starting the below upgrade procedure.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, that may raise the questions about the backup strategy 😄

@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch 2 times, most recently from da59354 to 5197374 Compare July 30, 2020 07:55
@ipochi ipochi requested review from invidian and rata July 30, 2020 07:56
invidian
invidian suggested changes Jul 30, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch 2 times, most recently from 073f4e4 to f9a8ddf Compare July 30, 2020 09:04
@ipochi ipochi requested a review from invidian July 30, 2020 09:05
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from f9a8ddf to 5398b11 Compare July 30, 2020 09:06
@ipochi
Copy link
Member Author

ipochi commented Jul 30, 2020

@invidian addressed all your review comments, please re-review.

@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from 5398b11 to cbd4090 Compare July 30, 2020 09:10
@invidian invidian changed the title Release : v0.3.0 Release v0.3.0 Jul 30, 2020
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from ba5d030 to 5025789 Compare July 30, 2020 14:30
invidian
invidian previously requested changes Jul 30, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from 5025789 to d061eeb Compare July 30, 2020 15:42
@ipochi ipochi requested a review from invidian July 30, 2020 15:43
@ipochi ipochi dismissed invidian’s stale review July 30, 2020 15:43

Addressed the review commnets, please re-review.

invidian
invidian reviewed Jul 30, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please re-organize the commits so I can approve.

@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from d061eeb to 89befb6 Compare July 30, 2020 16:30
invidian
invidian previously approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work @ipochi

@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from 89befb6 to 0b4e5cd Compare July 30, 2020 16:34
invidian
invidian previously approved these changes Jul 30, 2020
View reviewed changes
@ipochi
fix: add missing parantheses
79fa50e 
Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from 0b4e5cd to 7edfd9e Compare July 30, 2020 16:40
@ipochi ipochi requested a review from invidian July 30, 2020 16:53
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from 7edfd9e to c787d32 Compare July 30, 2020 16:54
invidian
invidian previously approved these changes Jul 30, 2020
View reviewed changes
knrt10
knrt10 previously approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 great work on the PR.

@rata rata mentioned this pull request Jul 31, 2020
Merged
rata
rata previously approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipochi very nice, thanks again!

Added one simple comment (don't need to review again) about the date: will be released on the 31 :-D

CHANGELOG.md Outdated Show resolved Hide resolved
ipochi added 3 commits July 31, 2020 21:24
@ipochi
CHANGELOG.md: add changelog for v0.3.0 release
bbad05c 
Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi
version: bump to v0.3.0
b48e09e 
Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi
version: bump to v0.3.0+git
e1a6830 
Signed-off-by: Imran Pochi <imran@kinvolk.io>
@ipochi ipochi dismissed stale reviews from rata, knrt10, and invidian via e1a6830 July 31, 2020 15:55
@ipochi ipochi force-pushed the ipochi/release-v0.3.0 branch from c787d32 to e1a6830 Compare July 31, 2020 15:55
@ipochi ipochi requested review from invidian, rata and knrt10 July 31, 2020 15:56
rata
rata approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The change was so small (corrected the date) that I'd consider previous approvals to still be valid :)

knrt10
knrt10 approved these changes Jul 31, 2020
View reviewed changes
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's hope this get's merged now 😄

@rata
Copy link
Member

rata commented Jul 31, 2020

More importantly: today 😂

@ipochi ipochi merged commit eed3505 into master Jul 31, 2020
@invidian invidian deleted the ipochi/release-v0.3.0 branch July 31, 2020 18:15
@invidian invidian mentioned this pull request Sep 2, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@knrt10 knrt10 knrt10 approved these changes

@invidian invidian invidian approved these changes

@rata rata rata approved these changes

@johananl johananl Awaiting requested review from johananl

@surajssd surajssd Awaiting requested review from surajssd

@iaguis iaguis Awaiting requested review from iaguis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ipochi @rata @invidian @knrt10