This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Expose Prometheus over ingress #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/expose-prometheus
branch
from
20a7248 to
1ab88b3
Compare
invidian
suggested changes
Jul 14, 2020
surajssd
force-pushed
the
surajssd/expose-prometheus
branch
from
1ab88b3 to
be75103
Compare
surajssd
force-pushed
the
surajssd/expose-prometheus
branch
from
0e4142c to
25fe7fd
Compare
|
Let's move ahead and create an issue to secure this. |
invidian
suggested changes
Jul 17, 2020
* This commit moves all the params that are Prometheus specific to its special block. * This helps us organise all the Prometheus specific variables under the `prometheus` block in the component config. Having these variables at the root level does not delineate clearly. This change improves the UI of the `prometheus-operator` component. * Update docs to show the move of Prometheus specific configs to the `prometheus` block. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- Allow user to use ingress to expose Prometheus. - Remove the variable `prometheus_external_url` since it is no longer needed. This information can be extracted from the `ingress.host` config. - Add docs to `prometheus-operator` configuration reference about the new block `ingress` inside the `prometheus` block. - Add docs to `Setting up monitoring on Lokomotive` on how to access Prometheus if exposed over the internet using Ingress. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- Modify the existing ingress test to accomodate testing multiple exposed ingresses. - This commit adds a test to verify if Prometheus is accessible over internet. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
* Adds a variable called `external_labels` which is helpful in federated clusters. This helps us identify the metrics from the cluster being queried with the help of these `external_labels`. * Adds the docs about the variable `external_labels` in the `prometheus` block in the `prometheus-operator` component. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/expose-prometheus
branch
from
36c4783 to
38eeaea
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: See changes per commit.