This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
terraform/aws/workers: fix upgrades from v0.1.0 #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though the new name is better, changing it will recreate the ASG when updating from v0.1.0. To avoid this we switch back to the old name. Co-authored-by: Mateusz Gozdek <mateusz@kinvolk.io>
Doing so will cause the LoadBalancer to be recreated by Terraform. First the new one will be created and then the old one will be destroyed. We need to do this because our LoadBalancers changed their health_check.matcher to TCP and modifying them in place is not supported by the AWS provider. Also, this uses an underscore instead of a dash to separate words, which better follows Terraform's conventions[[1]]. [1]: https://www.terraform.io/docs/extend/best-practices/naming.html#resource-names Co-authored-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
approved these changes
Jun 18, 2020
|
I did test this several times, so I'm fine with merging it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes LoadBalancer names and reverts ASG names to the old scheme so upgrades from v0.1.0 are smooth.
In a following release we can change the ASG name again and we can look into using something like
create_before_destroyto avoid downtime.