Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

readme: Add example gif #636

Merged
merged 1 commit into from
Jul 29, 2020
Merged

readme: Add example gif #636

merged 1 commit into from
Jul 29, 2020

Conversation

BrainBlasted
Copy link
Contributor

Related to #318

@knrt10
Copy link
Member

knrt10 commented Jun 17, 2020

@BrainBlasted is it possible for the video to be fast, I mean show the main working, skipping the 5-6 minute idle gap.

@iaguis
Copy link
Contributor

iaguis commented Jun 25, 2020

@BrainBlasted is it possible for the video to be fast, I mean show the main working, skipping the 5-6 minute idle gap.

Is this something you can do, @BrainBlasted?

@BrainBlasted
Copy link
Contributor Author

BrainBlasted commented Jun 25, 2020 via email

@BrainBlasted BrainBlasted force-pushed the cdavis/example-gif branch 2 times, most recently from d591800 to c78e8cf Compare June 29, 2020 16:45
@BrainBlasted
Copy link
Contributor Author

Pushed a new version with an edited gif.

Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @BrainBlasted . Looks right to me, just wanted to know if it's not to much work again will it be possible to add apply option without using confirm option, because you can easily so lokoctl cluster apply ? Rest everything is great :-)

invidian
invidian previously approved these changes Jun 30, 2020
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool! I think @knrt10 has a good idea to remove --confirm flag. I wonder, maybe it would also make sense to cat a config files to also show how you configure it? Of course, we would have to make sure that the configuration is very small, which I think should be achievable.

@BrainBlasted
Copy link
Contributor Author

Made requested changes :)

knrt10
knrt10 previously approved these changes Jul 23, 2020
Copy link
Member

@knrt10 knrt10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@iaguis
Copy link
Contributor

iaguis commented Jul 23, 2020

I think there's still a pretty big gap (40s), I edited the gif a bit so it's more engaging, maybe you can use it. What do you think?

lokomotive-example2

@BrainBlasted
Copy link
Contributor Author

I think this looks good :) Will incorporate it.

@BrainBlasted
Copy link
Contributor Author

I think this is ready now.

Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iaguis iaguis merged commit 39dff37 into master Jul 29, 2020
@iaguis iaguis deleted the cdavis/example-gif branch July 29, 2020 17:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants