-
Notifications
You must be signed in to change notification settings - Fork 47
Conversation
@BrainBlasted is it possible for the video to be fast, I mean show the main working, skipping the 5-6 minute idle gap. |
Is this something you can do, @BrainBlasted? |
Yes, though I need to figure out the right tools for gif editing, as my video editors can't seem to handle them.On Jun 25, 2020 9:08 AM, Iago López Galeiras <notifications@github.com> wrote:
@BrainBlasted is it possible for the video to be fast, I mean show the main working, skipping the 5-6 minute idle gap.
Is this something you can do, @BrainBlasted?
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe.
|
d591800
to
c78e8cf
Compare
Pushed a new version with an edited gif. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @BrainBlasted . Looks right to me, just wanted to know if it's not to much work again will it be possible to add apply option without using confirm option, because you can easily so lokoctl cluster apply
? Rest everything is great :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks cool! I think @knrt10 has a good idea to remove --confirm
flag. I wonder, maybe it would also make sense to cat
a config files to also show how you configure it? Of course, we would have to make sure that the configuration is very small, which I think should be achievable.
c78e8cf
to
a465db4
Compare
Made requested changes :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
I think this looks good :) Will incorporate it. |
Related to #318
a465db4
to
e98ff47
Compare
I think this is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Related to #318