This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pkg/components/util: improvements #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
force-pushed
the
invidian/improvements
branch
from
f81c75d to
2730ce3
Compare
surajssd
suggested changes
Jun 11, 2020
invidian
force-pushed
the
invidian/improvements
branch
from
2730ce3 to
289c132
Compare
invidian
force-pushed
the
invidian/improvements
branch
from
289c132 to
f6df532
Compare
Part of #290 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Previously, we had InstallAsRelease and InstallManifests to be able to conditionally install components using Helm and InstallComponent was a wrapper on those 2 functions, controlling this functionality. Now all components are being installed using Helm, so we no longer need InstallAsRelease, so it can be merged into InstallComponent function. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Now that we have component name available in metadata, we no longer need to pass it explicitly to this function. Part of #266 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/improvements
branch
from
f6df532 to
f05fd4e
Compare
knrt10
reviewed
Jun 16, 2020
This commit moves ensuring that release namespace exists code into separate function, so linter does not complain about function length and potentially allows to test this bit of code independently. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
force-pushed
the
invidian/improvements
branch
from
f05fd4e to
5e69aac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes dead code from
pkg/k8sutilpackage and simplifies the code a bit inpkg/components/utilpackage to make split of this package easier in the future.This PR also addresses some improvement proposals from #266.
This PR starts untangling the dependencies across our code base, which include:
cli/cmdpackage should not needpkg/k8sutil, but should use some higher-level abstraction for itpkg/components/util/helm.gocode should live in eitherpkg/componentsorpkg/components/helmLoadManifestsfrompkg/k8sutilpackage should live together withpkg/components/util/helm.gok8sutil.NewClientsetshould be moved tointernal/k8spackagetest/component/util.CreateKubeClientduplicated functionality ofk8sutil.NewClientset.CreateKubeClientshould useNewClientsetand only do error handling usingtesting.T