This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
docs: provide alternate way of declaring alertmanager config #570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipochi
force-pushed
the
imran/update-docs-for-434
branch
from
5f32580 to
1fc863d
Compare
invidian
suggested changes
Jun 5, 2020
ipochi
force-pushed
the
imran/update-docs-for-434
branch
from
1fc863d to
976f0fe
Compare
invidian
previously approved these changes
Jun 5, 2020
iaguis
previously requested changes
Jun 5, 2020
Addresses: #434 This commit adds a note to the user for adding the file to `.gitignore` to avoid leaking of sensitive data. We also provide an alternate way of providing alertmanager configuration to the component, instead of `file()` function we use the variable and store the content in `lokocfg.vars` Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/update-docs-for-434
branch
from
976f0fe to
b56633b
Compare
invidian
approved these changes
Jun 5, 2020
iaguis
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #434
This commit adds a note to the user for adding the file to
.gitignoreto avoid leaking of sensitive data.
We also provide an alternate way of providing alertmanager
configuration to the component, instead of
file()function we use thevariable and store the content in
lokocfg.varsSigned-off-by: Imran Pochi imran@kinvolk.io