This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
examples: make Flatcar channels explicit #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johananl
reviewed
Jun 4, 2020
| @@ -101,7 +101,7 @@ cluster "aws" { | |||
|
|
|||
| region = var.region | |||
|
|
|||
| enable_aggreation = true | |||
| enable_aggregation = true | |||
There was a problem hiding this comment.
Looks like this code snippet was never tested 😬
alban
force-pushed
the
alban/examples-channels
branch
from
0f41ecf to
ecf1013
Compare
alban
changed the title
invidian
reviewed
Jun 5, 2020
rata
reviewed
Jun 5, 2020
| @@ -57,6 +57,10 @@ cluster "packet" { | |||
| cluster_name = var.cluster_name | |||
| controller_count = var.controllers_count | |||
|
|
|||
| //os_channel = "stable" | |||
| //os_version = "current" | |||
There was a problem hiding this comment.
I think os_version doesn't work on Packet. We used preinstalled Flatcar images on amd64, so we can't choose the version, we just run "whatever the preinstalled version is".
On ARM we use IPXE, IIRC, and we can choose that, though
There was a problem hiding this comment.
I think for Packet, we could just set commented out os_channel value then.
There was a problem hiding this comment.
I can changed os_version to "" since that's the only value accepted without ipxe_script_url. It is commented.
alban
force-pushed
the
alban/examples-channels
branch
from
ecf1013 to
c94727f
Compare
|
Updated. |
invidian
reviewed
Jun 5, 2020
If Flatcar channels are not explicit, it is difficult for the user to find out how to change them. It also makes it less likely to forget to change it in the worker pool section.
alban
force-pushed
the
alban/examples-channels
branch
from
c94727f to
215889d
Compare
invidian
approved these changes
Jun 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Flatcar channels are not explicit, it is difficult for the user to find out how to change them. It also makes it less likely to forget to change it in the worker pool section.
Also fix a typo in the configuration.