Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Rook Ceph: Fix dashboard templating #476

Merged
merged 1 commit into from
May 27, 2020
Merged

Rook Ceph: Fix dashboard templating #476

merged 1 commit into from
May 27, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented May 22, 2020 •
edited
Loading

Graph after this fix:

Screenshot from 2020-05-26 10-43-09

Fixes #458

invidian
invidian previously approved these changes May 22, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but CI fails

@iaguis iaguis force-pushed the surajssd/fix-rook-chart-formatting branch 2 times, most recently from e773c8c to f858147 Compare May 25, 2020 12:08
iaguis
iaguis reviewed May 25, 2020
View reviewed changes
Copy link
Contributor

@iaguis iaguis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I'd like to have a some description of the change in the commit message. AFAIU there are three things fixed:

  • ceph_pool_bytes_used -> ceph_pool_stored
  • There was wrong escaping
  • Datasource is "null" now (why?)

@surajssd surajssd force-pushed the surajssd/fix-rook-chart-formatting branch 2 times, most recently from 8a94907 to 2970660 Compare May 26, 2020 08:28
@surajssd
Copy link
Member Author

I have changed the commit message to reflect the changes. Also that datasource problem was due to bad copying from upstream, and not fixing it.

@surajssd surajssd requested a review from iaguis May 26, 2020 08:30
@iaguis iaguis force-pushed the surajssd/fix-rook-chart-formatting branch from 2970660 to 3915a35 Compare May 26, 2020 09:36
@surajssd
Rook Ceph: Fix dashboard templating
c60a3d3 
* Metric `ceph_pool_bytes_used` changed to `ceph_pool_stored`.

* Fix the wrong escaping that caused templating issues.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/fix-rook-chart-formatting branch from 3915a35 to c60a3d3 Compare May 26, 2020 23:18
@surajssd surajssd requested a review from invidian May 27, 2020 09:17
invidian
invidian approved these changes May 27, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

iaguis
iaguis approved these changes May 27, 2020
View reviewed changes
Copy link
Contributor

@iaguis iaguis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@surajssd surajssd merged commit 0ba994d into master May 27, 2020
@surajssd surajssd deleted the surajssd/fix-rook-chart-formatting branch May 27, 2020 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@invidian invidian invidian approved these changes

@iaguis iaguis iaguis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rook Ceph Grafana dashboard templating errors
3 participants
@surajssd @iaguis @invidian