Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Add monitoring config and variable to rook component #405

Merged
merged 5 commits into from
May 11, 2020
Merged

Add monitoring config and variable to rook component #405

merged 5 commits into from
May 11, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented May 7, 2020

No description provided.

surajssd added 3 commits May 7, 2020 22:42
@surajssd
rook: Add monitoring config to the helm chart
c665685 
This commit adds ServiceMonitors, PrometheusRules, Grafana Dashboards to
the rook helm chart.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd
rook: Enable monitoring
13f9d3d 
This commit adds a boolean variable `enable_monitoring` to the rook
component to enable/disable monitoring of rook.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd
rook docs: Add enable_monitoring variable
43d1b14 
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd requested review from ipochi and invidian May 7, 2020 17:16
@surajssd surajssd requested a review from johananl as a code owner May 7, 2020 17:16
@surajssd
ci rook: Add the flag to enable monitoring
9aef772 
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd requested a review from pothos as a code owner May 8, 2020 07:18
invidian
invidian reviewed May 11, 2020
View reviewed changes
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajssd should we also add some tests for collecting metrics etc?

pkg/components/rook/component.go Show resolved Hide resolved
@invidian invidian mentioned this pull request May 11, 2020
Open
@surajssd
e2e rook: Add Prometheus Alert test
a389ce8 
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd
Copy link
Member Author

@invidian

should we also add some tests for collecting metrics etc?

It is not that simple to add e2e monitoring tests for this. So right now we install only rook component and not rook-ceph component. The metrics are emitted by manager pod and the OSD pods. And these pods only start once we have rook-ceph installed. Hence testing metrics does not make sense, since there are no metrics. The tests will simply fail. We can't test testComponentsPrometheusMetrics right now. But we can test testComponentAlerts(I have added test for this in last commit). And test testScrapeTargetRechability is automatic so we don't need to worry about it right now.

@surajssd surajssd merged commit 07fadff into master May 11, 2020
@surajssd surajssd deleted the surajssd/add-rook-ceph-monitoring branch May 11, 2020 07:56
@surajssd surajssd mentioned this pull request May 11, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@invidian invidian invidian approved these changes

@ipochi ipochi Awaiting requested review from ipochi

@johananl johananl Awaiting requested review from johananl

@pothos pothos Awaiting requested review from pothos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@surajssd @invidian