Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

rook-ceph: Add StorageClass config #402

Merged
merged 4 commits into from
May 11, 2020
Merged

rook-ceph: Add StorageClass config #402

merged 4 commits into from
May 11, 2020

Conversation

surajssd
Copy link
Member

@surajssd surajssd commented May 7, 2020

NOTE: To review this PR, please see the changes per commit.

Fixes: #381

surajssd added 2 commits May 7, 2020 19:04
When this module is enabled, Rook will configure all new pools with PG
autoscaling by setting:
`osd_pool_default_pg_autoscale_mode = on`.

This will ensure that we don't see warnings like:
`too few PGs per OSD (25 < min 30)`.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd requested review from iaguis and ipochi May 7, 2020 14:42
@surajssd surajssd requested review from invidian and johananl as code owners May 7, 2020 14:42
surajssd added 2 commits May 7, 2020 20:31
This commit adds config of Storage Class to rook-ceph.

Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
@surajssd surajssd force-pushed the surajssd/add-rook-sc branch from fd69701 to 0da5bea Compare May 7, 2020 15:01
Copy link
Member

@invidian invidian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one nit question.

pkg/components/rook-ceph/component.go Show resolved Hide resolved
@surajssd surajssd merged commit 8f34329 into master May 11, 2020
@surajssd surajssd deleted the surajssd/add-rook-sc branch May 11, 2020 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out a way to provide Rook Ceph as a storage for Prometheus Operator
2 participants