This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Add nodeAffinity and tolerations to contour #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
surajssd/add-nodeaffinity
branch
3 times, most recently
from
0304ad5 to
cc6bbb9
Compare
johananl
reviewed
May 4, 2020
Current `NodeSelector` struct is HCL implementation of `NodeAffinity` it is wrongly called `NodeSelector`. This commit fixes that erroneous naming. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This commit moves the config for envoy daemonset and contour operator deployment to the pkg so as to templatise it. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/add-nodeaffinity
branch
from
cc6bbb9 to
4780677
Compare
invidian
approved these changes
May 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: See changes per commit to know the gradual changes made.
Fixes #262