This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Show logs when terraform fails in lokoctl cluster apply/destroy
#323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
reviewed
Apr 22, 2020
| @@ -211,22 +213,50 @@ func (ex *Executor) execute(verbose bool, args ...string) error { | |||
| wg.Add(1) | |||
|
|
|||
| go tailFile(p, done, &wg) | |||
| } else { | |||
| fmt.Printf("\nYou can find the logs in %q\n", p) | |||
There was a problem hiding this comment.
I'm not really sure if this is needed. Also, it uses else 😄
There was a problem hiding this comment.
But then that is one of the requirement from the issue. What is wrong with using else?
There was a problem hiding this comment.
About using else: https://medium.com/@jamousgeorges/dont-use-else-66ee163deac3
When user is running `lokoctl cluster apply/destroy` without verbose flag `-v` then show user what is the location of log files. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/fix-terraform-ux
branch
2 times, most recently
from
405ad0b to
c79cb50
Compare
If a user is running `lokoctl cluster apply/destroy` without verbose flag `-v` and if there is an error in terraform execution then this will show last twenty lines from the logs. This will help user in knowing what went wrong. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/fix-terraform-ux
branch
from
c79cb50 to
3fbacfa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When user is using lokoctl cluster apply/destroy in normal mode (not verbose) then show users what went wrong by showing last 20 lines of the logs.
And also let user know where the log file resides.
Fixes #225