This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
docs: Add instructions to run conformance tests #236
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
suggested changes
Apr 1, 2020
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
from
April 1, 2020 13:56
744342c
to
e32bd90
Compare
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
from
April 1, 2020 14:14
e32bd90
to
90c0897
Compare
invidian
reviewed
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iaguis
suggested changes
Apr 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
3 times, most recently
from
April 2, 2020 09:24
3a129d3
to
254a2c3
Compare
iaguis
suggested changes
Apr 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nit, sorry 😅
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
2 times, most recently
from
April 2, 2020 11:52
c7b7594
to
2fb6c7d
Compare
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
This boolean type variable is used to expose node ports in the security group of AWS installation. By default this variable is set to `false`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
3 times, most recently
from
April 2, 2020 13:15
fa7c6b9
to
beba4a2
Compare
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/document-conformance-tests-run
branch
from
April 2, 2020 13:51
beba4a2
to
a17e3ec
Compare
iaguis
approved these changes
Apr 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
invidian
approved these changes
Apr 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89