This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Go module updates and cleanups #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Done automatically using gofumpt. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
They are not automatically removed by 'go mod tidy', but can be removed using sed -i '/indirect/d' go.mod. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
* Move file and dir modes to named constants. * Limit file and dir modes to only user for security. * Add error handling for executor operations on files. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Right now this message is printed from 2 places. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
This tests on AWS are very unstable and make CI fail very often. As we test this feature just fine on other platforms, I think it's OK to at least temporarily disable them on AWS, until we have more time to investigate it. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
|
Feel free to merge :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.