-
Notifications
You must be signed in to change notification settings - Fork 48
Rename Packet to Equinix Metal in existing Documentation. #1537
Conversation
This commit introduces renaming "Packet" to "Equinix Metal" in all files under `docs/concepts`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files under `docs/troubleshooting`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files under `docs/configuration-reference`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files under `docs/quickstarts`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
This commit introduces renaming "Packet" to "Equinix Metal" in all files under `docs/how-to-guides`. Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
Signed-off-by: Imran Pochi <imran@kinvolk.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, though I have some concerns about documentation talking about EM and code saying Packet all over the place. This is confusing for end user. I'd expect code changes to fall into the same release as this PR, so transition period is only "internally".
Also, this does not solve #1060, only partially addresses it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@invidian @knrt10 I disagree, IMHO this address the issue taking into account the comment that we added during the sprint planning: #1060 (comment) |
The user facing documentation is whats visible to the end user more so that any other piece of code/config. I understand your concern however, making it part of the single PR would have meant a possible delay of getting the user documentation changes merged, which was top priority anyway. Hence I closed the original issue #1060 , created another issue #1546 that tracks the code and config related changes from Packet to Equinix Metal. |
This PR replaces the name
Packet
withEquinix Metal
in all the existing documentation resources underdocs/
Fixes: #1060
This PR only takes care of renaming on the documentation side, more work and careful thought process would be required in migrating from Packet terraform provider to Equinix Metal terraform provider, such that there is little or no effect on existing clusters during upgrade.
More specifically, this migration guide will need to be followed
https://registry.terraform.io/providers/equinix/metal/latest/docs/guides/migration_guide_packet