This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maartje Eyskens <maartje@kinvolk.io>
- App: - Version: 1.1.0 - Release Notes: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/releases/tag/v1.1.0 - Chart: - Version: 1.2.3 - Release Notes: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/releases/tag/helm-chart-aws-ebs-csi-driver-1.2.3 Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/update-aws-csi-driver
branch
from
June 18, 2021 06:37
d07a5be
to
1357842
Compare
- This commit fixes the changed defaults by overriding the values file. - Fix tests for the changed results. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
ipochi
reviewed
Jun 18, 2021
ipochi
approved these changes
Jun 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
invidian
added
area/components
Items related to components
area/dependency-update
To label pending updates of upstream projects
labels
Jul 16, 2021
ipochi
added a commit
that referenced
this pull request
Sep 10, 2021
…-driver" This reverts commit 004294c, reversing changes made to 9f67cb3. This is reverted due to flakiness/issue of `aws-ebs-csi-driver` on Kubernetes version 1.21.4. `ebs-plugin` container panics due to not being able to query instance metadata: ``` W0909 10:57:15.342750 1 metadata.go:101] EC2 instance metadata is not available panic: error getting information from metadata service or node object: node providerID empty, cannot parse goroutine 1 [running]: github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.newNodeService(0xc00003a730, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0) /go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/node.go:88 +0x24c github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver.NewDriver(0xc00050ff40, 0x7, 0x7, 0xc000078660, 0xc00032ec30, 0x1fded28) /go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/pkg/driver/driver.go:94 +0x425 main.main() /go/src/github.com/kubernetes-sigs/aws-ebs-csi-driver/cmd/main.go:46 +0x212 ```
ipochi
added a commit
that referenced
this pull request
Sep 10, 2021
Revert "Merge pull request #1504 from kinvolk/surajssd/update-aws-csi-driver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area/components
Items related to components
area/dependency-update
To label pending updates of upstream projects
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.