This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
baremetal disable lvm mappings wipe additional disks #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pothos
reviewed
Jun 9, 2021
assets/terraform-modules/matchbox-flatcar/templates/install.yaml.tmpl
Outdated
Show resolved
Hide resolved
ipochi
force-pushed
the
imran/baremetal-disable-lvm-mappings-wipe-additional-disks
branch
2 times, most recently
from
d0c4304 to
2067cb0
Compare
pothos
previously approved these changes
Jun 17, 2021
ipochi
force-pushed
the
imran/baremetal-disable-lvm-mappings-wipe-additional-disks
branch
from
2067cb0 to
f0aa170
Compare
pothos
previously approved these changes
Jun 17, 2021
Since the disks may or not be not empty, any detected LVM partitions may automatically be activated on bootup. This can disrupt the installation and we need to disable them first. This was done for all "vg" prefixes but we can do it for any volume names. Any non-LVM entries are ignored with a small error log output. See flatcar/Flatcar#332
Exposes a variable to the user for wiping any additional disks attached to the machine. Default is false. When set to true, any additional disks attached to the hardware are wiped clean before proceeding with the Flatcar Container Linux installation. The reason this is being done is to provide clean and unformatted disk devices to the Lokomotive components [openebs and rook] for storage orchestration. Both rook and openebs fail to use the disks that have data or filesystem already present on the disk. This leads to among other issues, failed installation where PVCs get stuck in pending state. Signed-off-by: Imran Pochi <imran@kinvolk.io>
ipochi
force-pushed
the
imran/baremetal-disable-lvm-mappings-wipe-additional-disks
branch
from
f0aa170 to
45f770e
Compare
pothos
approved these changes
Jun 18, 2021
|
I'm not sure if it makes sense for me to review this PR. Perhaps someone more involved in maintenance should do this. |
ipochi
deleted the
imran/baremetal-disable-lvm-mappings-wipe-additional-disks
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables LVM partitions so that any detected LVM partitions are not automatically
activated on bootup disrupting the installation and wipes any additional disks attached to the
machine before proceeeding
This PR is in a series of multiple PRs that will be created to ease the review/acceptance/merge of a large PR #1402