This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
AWS EBS CSI Driver: Add node_affinity and tolerations.
#1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
invidian
reviewed
Feb 23, 2021
surajssd
force-pushed
the
surajssd/aws-ebs-driver-affinity-tolerations
branch
from
68529ac to
449405a
Compare
invidian
previously approved these changes
Feb 23, 2021
Comment on lines
+181
to
+188
| inputConfig: `component "aws-ebs-csi-driver" { | ||
| tolerations { | ||
| key = "lokomotive.io" | ||
| operator = "Equal" | ||
| value = "awesome" | ||
| effect = "NoSchedule" | ||
| } | ||
| }`, |
There was a problem hiding this comment.
Indentation is interesting in those test cases 😄 But I'm not sure what would be the right way to format it.
- This commit updates the component to version from `0.7.0` to `0.9.0`. - Remove the component specific change of allowing a SC to be default using annotation. Use the helm chart's default mechanism to provide storage class. - Change the default reclaim policy in StorageClass to `Retain`. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
- This commit adds two params to the component viz. `node_affinity` and `tolerations`. - Add unit tests for the same. - Add documentation to configuration reference docs. Signed-off-by: Suraj Deshmukh <suraj@kinvolk.io>
surajssd
force-pushed
the
surajssd/aws-ebs-driver-affinity-tolerations
branch
from
449405a to
53341f1
Compare
invidian
approved these changes
Feb 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update component from
0.7.0to0.9.0.Remove the component specific change of allowing a SC to be default
using annotation. Use the helm chart's default mechanism to provide
storage class.
This PR adds two params to the component viz.
node_affinityandtolerations.Add unit tests for the same.
Add documentation to configuration reference docs.
Fixes: #1385