This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
pkg/platform/packet: improve hardware reservations validation rules #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make them more readable. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
To make them easier to read and to allow adding new cases easily. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
This is to prevent emptying reservation ID field for a node, which would result in heterogenous pool, which we do not support. It will also partially prevent hitting #1156. Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
To avoid situations, where we create heterogenous pools, which are not supported due to Terraform dependencies limitations. Refs #1156 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Otherwise we may let some nodes to be created without hardware reservations. Refs #1156 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
changed the title
iaguis
suggested changes
Nov 18, 2020
Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
deleted the
invidian/packet-improve-hardware-reservations-validation-rules
branch
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Closes #1156