Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

metrics-server: update metrics server to 2.11.2 #1116

Merged
merged 1 commit into from
Oct 28, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/charts/components/metrics-server/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ maintainers:
name: metrics-server
sources:
- https://github.com/kubernetes-incubator/metrics-server
version: 2.11.1
version: 2.11.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chart still ships metrics-server v0.3.6, we could upgrade to v0.3.7.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not wait for the official release of the helm chart ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with waiting, I'm just saying there is new image available :)

3 changes: 3 additions & 0 deletions assets/charts/components/metrics-server/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,6 @@ Parameter | Description | Default
`podDisruptionBudget.minAvailable` | Minimum available instances; ignored if there is no PodDisruptionBudget |
`podDisruptionBudget.maxUnavailable` | Maximum unavailable instances; ignored if there is no PodDisruptionBudget |
`extraContainers` | Add additional containers | `[]`
`testImage.repository` | Image repository and name for test pod. See also `imagePullSecrets` | `busybox`
`testImage.tag` | Image tag for test pod | `latest`
`testImage.pullPolicy` | Image pull policy for test pod | `IfNotPresent`
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,11 @@ kind: RoleBinding
metadata:
name: {{ template "metrics-server.fullname" . }}-auth-reader
namespace: kube-system
annotations:
meta.helm.sh/release-name: {{ .Release.Name }}
meta.helm.sh/release-namespace: {{ .Release.Namespace }}
labels:
app: {{ template "metrics-server.name" . }}
chart: {{ template "metrics-server.chart" . }}
release: {{ .Release.Name }}
heritage: {{ .Release.Service }}
app.kubernetes.io/managed-by: Helm
roleRef:
apiGroup: rbac.authorization.k8s.io
kind: Role
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,16 @@ metadata:
spec:
containers:
- name: wget
image: busybox
image: "{{ .Values.testImage.repository }}:{{ .Values.testImage.tag }}"
imagePullPolicy: {{ .Values.testImage.pullPolicy }}
command: ['/bin/sh']
args:
- -c
- 'wget -qO- https://{{ include "metrics-server.fullname" . }}:{{ .Values.service.port }}/version | grep -F {{ .Values.image.tag }}'
{{- if .Values.imagePullSecrets }}
imagePullSecrets:
{{- range .Values.imagePullSecrets }}
- name: {{ . }}
{{- end }}
{{- end }}
restartPolicy: Never

5 changes: 5 additions & 0 deletions assets/charts/components/metrics-server/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -107,3 +107,8 @@ podDisruptionBudget:
enabled: false
minAvailable:
maxUnavailable:

testImage:
repository: busybox
tag: latest
pullPolicy: IfNotPresent
18 changes: 9 additions & 9 deletions pkg/assets/generated_assets.go

Large diffs are not rendered by default.