This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Fix dex pod reload on config change #1040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes: #1039 Signed-off-by: knrt10 <kautilya@kinvolk.io> Co-authored-by: Mateusz Gozdek <mateusz@kinvolk.io>
surajssd
suggested changes
Oct 1, 2020
This might be complex, as our e2e test suite do not have access to cluster configuration to modify it... What is your idea to test this @surajssd ? |
|
@invidian I had a talk with Suraj offline and I think this should be like this.
What do you think? I am little confused. Can we update it via client-go? |
It can only be updated via Helm render, as it's Helm template which generates the checksum. |
|
In that case we can have a render test locally, which verifies that the annotations change on each render. |
knrt10
force-pushed
the
knrt10/fix-dex-config-reload
branch
from
cfd9b44 to
c2952ea
Compare
invidian
suggested changes
Oct 1, 2020
On every render helm template will generate the checksum which will be different for unique config. Which in turn will regenerate pods for deployment on config change. Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10
force-pushed
the
knrt10/fix-dex-config-reload
branch
from
c2952ea to
405c204
Compare
surajssd
approved these changes
Oct 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1039
Signed-off-by: knrt10 kautilya@kinvolk.io
Co-authored-by: Mateusz Gozdek mateusz@kinvolk.io