Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Consistently use HasErrors() for error handling from diagnostics #994

Open
invidian opened this issue Sep 22, 2020 · 0 comments
Open

Consistently use HasErrors() for error handling from diagnostics #994

invidian opened this issue Sep 22, 2020 · 0 comments
Labels
technical-debt Technical debt-related issues

Comments

@invidian
Copy link
Member

Currently we either check for nil or len() == 0 when receiving diagnostics from function. We should decide which method to use for checking and do it consistently. Ideally this should end up in the style guide.

@invidian invidian added the technical-debt Technical debt-related issues label Sep 23, 2020
invidian added a commit that referenced this issue Sep 25, 2020
Part of #994.

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
technical-debt Technical debt-related issues
Projects
None yet
Development

No branches or pull requests

1 participant