Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

Run codespell in CI #573

Closed
invidian opened this issue Jun 5, 2020 · 1 comment
Closed

Run codespell in CI #573

invidian opened this issue Jun 5, 2020 · 1 comment
Labels
area/ci Items related to CI kind/enhancement New feature or request

Comments

@invidian
Copy link
Member

invidian commented Jun 5, 2020 •
edited
Loading

To avoid adding typos to the code base and wiki pages, we should run codespell as part of the CI.

The following command can be used right now to check the project for all typos:

codespell  --skip ./vendor,./.git,./lokoctl,*.png,./assets/components/rook-ceph,./assets/components/prometheus-operator/manifests,./assets/components/velero,./assets/components/cluster-autoscaler,./assets/components/contour/crds --ignore-words-list aks,aci,cas --check-filenames --check-hidden
@invidian invidian added area/ci Items related to CI kind/enhancement New feature or request labels Jun 5, 2020
invidian added a commit that referenced this issue Jun 24, 2020
@invidian
Makefile: add codespell target with configuration
3f3620f 
This commit adds 'codespell' target to the Makefile and adds it to 'all'
target, so it is run when all checks are requested, but only if the
binary is present, as some people may not have it installed.

Part of #573

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian invidian mentioned this issue Jun 24, 2020
Merged
invidian added a commit that referenced this issue Jun 24, 2020
@invidian
Makefile: add codespell target with configuration
ecfb2ea 
This commit adds 'codespell' target to the Makefile and adds it to 'all'
target, so it is run when all checks are requested, but only if the
binary is present, as some people may not have it installed.

Part of #573

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian added a commit that referenced this issue Jun 25, 2020
@invidian
Makefile: add codespell target with configuration
a16fc2e 
This commit adds 'codespell' target to the Makefile and adds it to 'all'
target, so it is run when all checks are requested, but only if the
binary is present, as some people may not have it installed.

Part of #573

Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
@invidian
Copy link
Member Author

invidian commented Aug 5, 2020

This is done since a while now.

@invidian invidian closed this as completed Aug 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/ci Items related to CI kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@invidian