This repository has been archived by the owner on Jun 29, 2022. It is now read-only.
Allow installing prometheus-operator CRDs before prometheus-operator itself #557
Labels
Comments
invidian
added
kind/enhancement
|
We discussed it on Slack and "dummy" way should be OK for now and will improve things a bit. We can later lift the user requirement by handling dependencies automatically, so it will also be backward compatible. |
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit adds prometheus-operator-crds component, which will replace the CRDs installed by prometheus-operator component, to resolve circular dependency issue between prometheus-operator and component providing storage. Refs #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit adds prometheus-operator-crds component, which will replace the CRDs installed by prometheus-operator component, to resolve circular dependency issue between prometheus-operator and component providing storage. Refs #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 4, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 5, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 8, 2020
This commit adds prometheus-operator-crds component, which will replace the CRDs installed by prometheus-operator component, to resolve circular dependency issue between prometheus-operator and component providing storage. Refs #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
invidian
added a commit
that referenced
this issue
Jun 8, 2020
This commit removes prometheus-operator CRDs from prometheus-operator component and changes 'examples' and 'ci' cluster configuration files to use new 'prometheus-operator-crds' component, so monitoring can be easily enabled for storage solution without circular dependency. Also documentation of prometheus-operator component is changed to reflect the requirement on prometheus-operator-crds component. Closes #557 Signed-off-by: Mateusz Gozdek <mateusz@kinvolk.io>
iaguis
added
proposed/next-sprint
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
To avoid chicken-egg issues with storage provider and prometheus-operator deployment like described in #433, we should have a way to install prometheus-operator CRDs before other components, so they can enable their monitoring from the very beginning. We could then even enable the monitoring by default and it would be left unused until user installs
prometheus-operatorcomponent.One "dummy" way would be to put the CRDs in separate component and then just inform users about correct ordering while configuring the cluster. More flexible way would be to dynamically pull this component as a dependency, when monitoring is enabled by other components.
The text was updated successfully, but these errors were encountered: