Skip to content
This repository has been archived by the owner on Jun 29, 2022. It is now read-only.

CoreDNS is not version tagged #374

Closed
surajssd opened this issue Apr 28, 2020 · 0 comments · Fixed by #1203
Closed

CoreDNS is not version tagged #374

surajssd opened this issue Apr 28, 2020 · 0 comments · Fixed by #1203
Assignees
Labels
area/components Items related to components bug Something isn't working low-hanging-fruit Issues good for beginners

Comments

@surajssd
Copy link
Member

surajssd commented Apr 28, 2020

We deploy CoreDNS with latest tag and not with image tag. This was done for providing support of the ARM arch. But this needs to change and we need to find a way to pin down the version of CoreDNS.

variable "container_arch" {
description = "Architecture suffix for the container image coredns/coredns:coredns- (e.g., arm64)"
type = string
default = "amd64"
}
variable "container_images" {
description = "Container images to use (the coredns entry will get -$${var.container_arch} appended)"
type = map(string)
default = {
calico = "calico/node:v3.13.3"
calico_cni = "calico/cni:v3.13.3"
calico_controllers = "calico/kube-controllers:v3.13.3"
hyperkube = "k8s.gcr.io/hyperkube:v1.18.2"
coredns = "coredns/coredns:coredns-"

Q: Why can't we rely on the ability of the docker daemon to identify the arch and pull the corresponding image?

You can find the various tags for CoreDNS https://hub.docker.com/r/coredns/coredns/tags

@surajssd surajssd added area/components Items related to components bug Something isn't working labels Aug 6, 2020
@invidian invidian added the low-hanging-fruit Issues good for beginners label Nov 19, 2020
@knrt10 knrt10 self-assigned this Nov 23, 2020
knrt10 added a commit that referenced this issue Nov 23, 2020
Let docker daemon figure out the architecture and use version 1.8.0

closes: #374
Signed-off-by: knrt10 <kautilya@kinvolk.io>
knrt10 added a commit that referenced this issue Nov 23, 2020
Let docker daemon figure out the architecture and use version 1.8.0

closes: #374
Signed-off-by: knrt10 <kautilya@kinvolk.io>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/components Items related to components bug Something isn't working low-hanging-fruit Issues good for beginners
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants