Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parse exception when TimeField initial value is not set #55

Conversation

chikamura
Copy link
Contributor

@chikamura chikamura commented Jun 18, 2024

When the initial value of TimeField is not set, the get fields api returns the default value as an empty string.
This cause TimeField parse exception in getFormFields. This PR fixes that.

スクリーンショット 2024-06-18 18 31 18
Text '' could not be parsed at index 0 (through reference chain: com.kintone.client.api.app.GetFormFieldsResponseBody["properties"]->java.util.LinkedHashMap["TIME"]->com.kintone.client.model.app.field.TimeFieldProperty["defaultValue"])
	at 
...
> curl -s -XGET "https://${HOST}/k/v1/app/form/fields.json?app=${APP_ID}" -H "X-Cybozu-Authorization: ${KINTONE_CRED}" | jq .properties.TIME.defaultValue
""

@chikamura chikamura marked this pull request as ready for review June 18, 2024 09:39
@chikamura
Copy link
Contributor Author

@tomohiro-okuyama Could you please review it?

@tomohiro-okuyama
Copy link
Contributor

@chikamura
Thank you for your report!
I think the fix is sufficient, so we'd like to merge this PR soon.

@chikamura
Copy link
Contributor Author

Many thanks! 🙏

@tomohiro-okuyama tomohiro-okuyama merged commit 8ff56e7 into kintone:master Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants