Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rest-api-client): throw an error if location is undefined on browser #1590

Merged
merged 3 commits into from
Jun 27, 2022
Merged

fix(rest-api-client): throw an error if location is undefined on browser #1590

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4217193
fix(rest-api-client): throw an error if location undefined on browser
tasshi-me Jun 27, 2022
7274640
Merge branch 'master' into fix/throw-error-if-location-not-defined
tasshi-me Jun 27, 2022
d739f27
chore: update error message
tasshi-me Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/rest-api-client/src/platform/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,11 @@ export const buildBaseUrl = (baseUrl?: string) => {
return baseUrl;
}

// eslint-disable-next-line @typescript-eslint/no-non-null-assertion
const { host, protocol } = location!;
if (location === undefined) {
throw new Error("The baseUrl parameter is required for this environment");
}

const { host, protocol } = location;

return `${protocol}//${host}`;
};
Expand Down