Fix building on NetBSD #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Usually projects in this situation would rename the static inline function. I am just not sure what function name you would like to use. |
brad0
force-pushed
the
netbsd_popcount64
branch
from
ff89711 to
94d09cf
Compare
The static inline function popcount64() conflicts with a function with NetBSD's libc. https://man.netbsd.org/popcount.3
brad0
force-pushed
the
netbsd_popcount64
branch
from
94d09cf to
bace659
Compare
I renamed it to |
Thank you. I figured you would have another name. Perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The static inline function popcount64() conflicts with a function
with NetBSD's libc.
https://man.netbsd.org/popcount.3